Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-7025] Fix configure save button disable. #2491

Open
wants to merge 1 commit into
base: feature/addon-services
Choose a base branch
from

Conversation

adlius
Copy link
Contributor

@adlius adlius commented Jan 28, 2025

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@adlius adlius changed the title Fix configure save button disable. [ENG-7025] Fix configure save button disable. Jan 28, 2025
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have a test failure. Otherwise this looks simple enough. Although what if somebody just wants to change the configured name, but not the root folder? It may be that you need something a bit more involved here.

9) [Chrome 132.0] Exam Partition 2 - Acceptance | guid-node/addons: Editing configured addons
     Folder path shown

     expected: 'Element [data-test-folder-path-option] exists once'
       actual: 'Element [data-test-folder-path-option] does not exist'

         at DOMAssertions.exists (http://localhost:7357/assets/test-support-12fc02365e5481148ca8a29243ac90b6.js:30141:12)
         at DOMAssertions.exists (http://localhost:7357/assets/test-support-12fc02365e5481148ca8a29243ac90b6.js:30530:14)
         at Object.<anonymous> (http://localhost:7357/assets/tests-368bb424cfaedd3652053511f5e4ff92.js:932:52)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants