forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of rust-lang#67458 - pnkfelix:fix-66530-by-propagating-fat…
…al-error-from-worker, r=matthewjasper When a codegen worker has a FatalError, propagate it instead of ICE'ing. Fix rust-lang#66530
- Loading branch information
Showing
3 changed files
with
61 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Issue #66530: We would ICE if someone compiled with `-o /dev/null`, | ||
// because we would try to generate auxiliary files in `/dev/` (which | ||
// at least the OS X file system rejects). | ||
// | ||
// An attempt to `-o` into a directory we cannot write into should indeed | ||
// be an error; but not an ICE. | ||
|
||
// compile-flags: -o /dev/null | ||
|
||
// The error-pattern check occurs *before* normalization, and the error patterns | ||
// are wildly different between build environments. So this is a cop-out (and we | ||
// rely on the checking of the normalized stderr output as our actual | ||
// "verification" of the diagnostic). | ||
|
||
// error-pattern: error | ||
|
||
// On Mac OS X, we get an error like the below | ||
// normalize-stderr-test "failed to write bytecode to /dev/null.non_ice_error_on_worker_io_fail.*" -> "io error modifying /dev/" | ||
|
||
// On Linux, we get an error like the below | ||
// normalize-stderr-test "couldn't create a temp dir.*" -> "io error modifying /dev/" | ||
|
||
// ignore-tidy-linelength | ||
// ignore-windows - this is a unix-specific test | ||
// ignore-emscripten - the file-system issues do not replicate here | ||
// ignore-wasm - the file-system issues do not replicate here | ||
// ignore-arm - the file-system issues do not replicate here, at least on armhf-gnu | ||
|
||
#![crate_type="lib"] | ||
|
||
#![cfg_attr(not(feature = "std"), no_std)] | ||
pub mod task { | ||
pub mod __internal { | ||
use crate::task::Waker; | ||
} | ||
pub use core::task::Waker; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
warning: ignoring --out-dir flag due to -o flag | ||
|
||
error: io error modifying /dev/ | ||
|
||
error: aborting due to previous error | ||
|