Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move traits to primitives #250

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Move traits to primitives #250

merged 4 commits into from
Jan 25, 2024

Conversation

rakanalh
Copy link
Contributor

Description

Traits are primitive data types which are used across the pallets & runtime. Being in a separate module in the root directory does not make sense.

Types of Changes

  • Tech Debt (Code improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

  • This change requires a runtime migration.
  • Modifies on_initialize
  • Modifies on_finalize

Checklist

  • Change has been tested locally.
  • Change adds / updates tests.
  • Changelog doc updated.

@auto-assign auto-assign bot requested a review from yahortsaryk January 25, 2024 08:34
@rakanalh rakanalh merged commit 3d4034e into dev Jan 25, 2024
5 checks passed
@rakanalh rakanalh deleted the move-traits-to-primitives branch January 25, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahortsaryk yahortsaryk yahortsaryk approved these changes

Assignees

@rakanalh rakanalh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakanalh @yahortsaryk