Skip to content

Commit

Permalink
test: stabilize the inspector-open-dispose test
Browse files Browse the repository at this point in the history
Ref: https://ci.nodejs.org/job/node-test-commit-osx-arm/nodes\=osx11/12543/console, nodejs/reliability#631
PR-URL: nodejs#49000
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
atlowChemi authored and Ceres6 committed Aug 14, 2023
1 parent f8e1ac3 commit 42d0360
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ if (process.env.BE_CHILD) {

child.once('message', common.mustCall((msg) => {
assert.strictEqual(msg.cmd, 'started');
assert.strictEqual(msg.url, undefined);

child.send({ cmd: 'open', args: [] });
child.send({ cmd: 'open' });
child.once('message', common.mustCall(wasOpenedHandler));
}));

function wasOpenedHandler(msg) {
assert.strictEqual(msg.cmd, 'url');
const port = url.parse(msg.url).port;
const { port } = url.parse(msg.url);
ping(port, common.mustSucceed(() => {
// Inspector is already open, and won't be reopened, so args don't matter.
child.send({ cmd: 'dispose' });
child.once('message', common.mustCall(wasDisposedWhenOpenHandler));
firstPort = port;
Expand All @@ -35,7 +35,7 @@ if (process.env.BE_CHILD) {
assert.strictEqual(msg.cmd, 'url');
assert.strictEqual(msg.url, undefined);
ping(firstPort, (err) => {
assert(err);
assert(err, 'expected ping to inspector port to fail');
child.send({ cmd: 'dispose' });
child.once('message', common.mustCall(wasReDisposedHandler));
});
Expand Down

0 comments on commit 42d0360

Please sign in to comment.