Miscellaneous cleanup and code generator changes (part 2) #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #409
@IanLilleyT and I have been battle testing the code generator with a variety of glTF and 3D Tiles extensions. The changes have been extracted out here so that future PRs will be easier to review.
EXT_feature_metadata
andEXT_mesh_features
simultaneously. The main thing here was adding more overrides toglTF.json
. This technique relies on the schema titles to be unambiguous. In the future we might need a mapping from <extension name, title> to override name.tileset.schema.json
andsubtree.schema.json
which are independent schemas but belong to the same projectCesium3DTiles
.Other changes
GltfReader::readModel
,ModelReaderResult
, andReadModelOptions
toGltfReader::readGltf
,GltfReaderResult
, andGltfReaderOptions
. This is for better symmetry with the GltfWriter API in Update GltfWriter to use autogenerated files #416 and the TilesetReader and TilesetWriter APIs.TilesetWriterOptions
for writing tilesets. The only option right now isprettyPrint
, which defaults to false.CESIUM_TESTS_ENABLED
option to the build systemTestReader
toTestTilesetReader
TestReader
toTestGltfReader
TestModelEXT_feature_metadata
toTestExtensionModelExtFeatureMetadata