Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #787

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update README.md #787

merged 1 commit into from
Jan 9, 2024

Conversation

jherico
Copy link
Contributor

@jherico jherico commented Jan 4, 2024

Fix build status badge to point to Github Actions instead of Travis

Fix build status badge to point to Github Actions instead of Travis
@kring
Copy link
Member

kring commented Jan 8, 2024

Thanks @jherico! I just noticed we don't seem to have a Contributor License Agreement from you yet. Can I please bug you to sign it?
https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla

@jherico
Copy link
Contributor Author

jherico commented Jan 8, 2024

@kring done. It doesn't seem to be workflow related but I know some other repositories seem to automatically check for CLA signature as part of the PR checks mechanism, such as in this PR: google/s2geometry#338

Not sure how that's set up, but might be worth looking into to automate that check and prompt non-signatories to sign without the need for human intervention.

@kring
Copy link
Member

kring commented Jan 9, 2024

Thanks @jherico! Yes agreed CLAs should be automated. Some other folks at Cesium are working on setting that up.

@kring kring merged commit a0225ff into CesiumGS:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants