Merge pull request #739 from CesiumGS/fix-smooth-normals

Fix smooth normals crash
CesiumGS · Oct 5, 2024 · e55dc6e · e55dc6e
2 parents b4831ba + 8f09694
commit e55dc6e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,9 @@
 # Change Log
 
+### v0.24.0 - 2024-11-01
+
+* Fixed bug where smooth normals setting would crash.
+
 ### v0.23.0 - 2024-10-01
 
 * Fixed bug where tilesets and raster overlays were not being passed the correct custom ellipsoid.

diff --git a/src/core/src/FabricVertexAttributeAccessors.cpp b/src/core/src/FabricVertexAttributeAccessors.cpp
@@ -163,8 +163,8 @@ NormalsAccessor NormalsAccessor::GenerateSmooth(const PositionsAccessor& positio
     }
 
     auto accessor = NormalsAccessor();
+    accessor._size = normals.size();
     accessor._computed = std::move(normals);
-    accessor._size = indices.size();
     return accessor;
 }