Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug window cleanup #230

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Debug window cleanup #230

merged 2 commits into from
Mar 20, 2023

Conversation

weegeekps
Copy link
Contributor

Removed the ability to add tilesets via the debug window. This is no longer needed.

@weegeekps weegeekps changed the base branch from main to separate-usd-plugins-ext March 20, 2023 21:59
@weegeekps weegeekps changed the base branch from separate-usd-plugins-ext to updated-readme March 20, 2023 21:59
@lilleyse
Copy link
Contributor

Looks good, I'll merge once #229 is merged.

@lilleyse
Copy link
Contributor

Actually, one thing. The "Open Troubleshooter" button isn't working. Could be an easy fix. Or we could remove it?

2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: Exception ignored in: 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: <function CesiumTroubleshooterWindow.__del__ at 0x000001D10B9B2DC8>
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: Traceback (most recent call last):
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]:   File "c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\troubleshooter_window.py", line 81, in __del__
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]:     
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: self.destroy()
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]:   File "c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\troubleshooter_window.py", line 84, in destroy
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]:     
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: for subscription in self._subscriptions:
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: AttributeError
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: : 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: 'CesiumTroubleshooterWindow' object has no attribute '_subscriptions'
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:11  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:11  [Error] [omni.ui.python] TypeError: __init__() missing 1 required positional argument: 'message'
2023-03-20 22:50:11  [Error] [omni.ui.python] 
2023-03-20 22:50:11  [Error] [omni.ui.python] At:
2023-03-20 22:50:11  [Error] [omni.ui.python]   c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\debug_window.py(55): open_troubleshooting_window
2023-03-20 22:50:11  [Error] [omni.ui.python]   c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\debug_window.py(60): <lambda>
2023-03-20 22:50:11  [Error] [omni.ui.python] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: Exception ignored in: 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: <function CesiumTroubleshooterWindow.__del__ at 0x000001D10B9B2DC8>
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: Traceback (most recent call last):
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]:   File "c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\troubleshooter_window.py", line 81, in __del__
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]:     
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: self.destroy()
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]:   File "c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\troubleshooter_window.py", line 84, in destroy
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]:     
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: for subscription in self._subscriptions:
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: AttributeError
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: : 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: 'CesiumTroubleshooterWindow' object has no attribute '_subscriptions'
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] [py stderr]: 
2023-03-20 22:50:24  [Error] [omni.kit.app._impl] 
2023-03-20 22:50:24  [Error] [omni.ui.python] TypeError: __init__() missing 1 required positional argument: 'message'
2023-03-20 22:50:24  [Error] [omni.ui.python] 
2023-03-20 22:50:24  [Error] [omni.ui.python] At:
2023-03-20 22:50:24  [Error] [omni.ui.python]   c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\debug_window.py(55): open_troubleshooting_window
2023-03-20 22:50:24  [Error] [omni.ui.python]   c:\users\slilley\code\cesium-omniverse\exts\cesium.omniverse\cesium\omniverse\ui\debug_window.py(60): <lambda>
2023-03-20 22:50:24  [Error] [omni.ui.python]

Base automatically changed from updated-readme to main March 20, 2023 23:16
@lilleyse lilleyse merged commit ffcdc98 into main Mar 20, 2023
@lilleyse lilleyse deleted the debug-window-cleanup branch March 20, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilleyse lilleyse Awaiting requested review from lilleyse

@r-veenstra r-veenstra Awaiting requested review from r-veenstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weegeekps @lilleyse