builds now use larger runners and windows returns to github runners #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattelser
requested review from
lilleyse,
weegeekps,
r-veenstra and
corybarr
as code owners
lilleyse
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #324. Github opened a beta for larger runners, which fixes the problem of CentOS builds running OOM, which is a pretty simple drop-in replacement. It also allows us to bring windows builds back to github from the current self-hosted runner, which was a bit more involved.
Part of moving the windows builds back to github is adjusting the
conansetup. The self-hosted runner placed the conan home dir on a separate volume (explained here), but this no longer seems necessary so I've removed thed:\. Also this move was potentially causing us to not find the conan home dir as a result of the previously cached docker image containing the conan dir in a different location. As a result we've incremented the cache busting counter.