Add support for assigning materials to a tileset #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
requested review from
weegeekps,
r-veenstra,
corybarr and
mattelser
as code owners
weegeekps
approved these changes
Jul 13, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Merge #389 first
Adds support for assigning materials to a tileset. The assigned material overrides the existing glTF material and imagery layers.
CesiumTilesetPrim now inherits from UsdGeomGprim in order for materials to be assigned to it.
In a future PR we may create our own mdl shader nodes that allow people to use the tileset's textures, material properties, and imagery layers in their own materials. This would be needed for more complex materials like texture-based clipping.
There seems to be a Fabric population bug where assigning a material doesn't work unless you enable fabric scene delegate after load. So in order to test this with
cesium.omniverse.devyou'll need to setapp.useFabricSceneDelegate = false.material-assignment.mp4