Powertools for syncing Sun Study with CesiumGeoreference #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-veenstra
requested review from
lilleyse,
weegeekps,
corybarr and
mattelser
as code owners
weegeekps
approved these changes
Jul 28, 2023
lilleyse
reviewed
Jul 31, 2023
Comment on lines
+72
to
+73
| north_attr = get_or_create_attribute(environment_prim, "location:north_orientation", Sdf.ValueTypeNames.Float) | ||
| north_attr.Set(90.0) # Always set to 90, otherwise the sun is at the wrong angle |
There was a problem hiding this comment.
Just checking, is this fix needed for both y-up and z-up stages?
There was a problem hiding this comment.
Yes, I checked both when implementing. NVIDIA also bakes the 90 degree rotation into all of their exports via their connectors from AEC software.
lilleyse
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small additions to powertools here:
A simple button in the Powertools menu to set Sun Study latitude/longitude based on the current CesiumGeoreference latitude/longitude. This also ensures the north angle is set to 90 degrees, which is required to ensure the sun is at the correct yaw compared to the globe.
An addition to the Georeference Helper which will extract latitude/longitude from the Environment prim and set the CesiumGeoreference to match. This is useful as some of the Omniverse connectors such as Rhino + Sketchup store the latitude and longitude values from the export in environment prim.