Release FabricMeshes stored in TileLoadThreadResult #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tile made it through
prepareInLoadThread
but notprepareInMainThread
its fabric meshes would not be released back into the pool, causing a memory leak.The bug was introduced in #389 - fabric meshes were added to the
TileLoadThreadResult
struct but they were not being released infree
.You can see the fix in action by adding a tileset, removing the tileset, and looking at the pool capacity. Previously the pool capacity would not return back to 2048.