Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach for adding new tokens was overly complex, requiring changes in 5 different places within
Tokens.h
andTokens.cpp
. Now it's as simple as adding a new token toUSD_TOKENS
and letting the macros do the rest of the work.USD tokens are now created in a more standard way with
TF_DECLARE_PUBLIC_TOKENS
andTF_DEFINE_PUBLIC_TOKENS
and are accessed aspxr::UsdTokens->tokenName
.Fabric tokens are created with
FABRIC_DECLARE_TOKENS
andFABRIC_DEFINE_TOKENS
which are inspired by the pxr macros and are accessed asFabricTokens::tokenName
like before.