Build and CI improvements, building on vcpkg #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were assuming all generated code was ours, and including it all in the built package. In Unity 2022.3, this assumption no longer holds.
The JDK module name was deduced by running: ``` "C:/Program Files/Unity Hub/Unity Hub.exe" -- --headless install-modules --version 2022.3.41f1 --changeset 0f988161febf --module android android-sdk-ndk-tools android-open-jdk universal-windows-platform uwp-il2cpp ``` And replacing android-sdk-ndk-tools with Unity's recommendation.
Sometimes, during the tests, the managed CesiumIonSession could get garbage collected before the requests made as part of the "resume" completed. Because we were using the corresponding Impl class in the continuations, and the Impl class's lifetime is controlled by the lifetime of the managed object, this would sometimes cause a crash. The solution implemented here is to make sure the continuations also keep the managed instance alive. We also check to see if the held managed instance becomes nullptr, which handles causes like AppDomain unload.
So hopefully we'll get ARM on ARM.
If we don't specify, it sits there waiting for us to choose.
This will hopefully drastically speed up the macOS build because it won't have to wait ages for the audio system to time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #479, and I'm going to merge it immediately now that I'm happy with it.