Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frustum debugging #1073

Merged
merged 16 commits into from
Aug 27, 2013
Merged

Frustum debugging #1073

merged 16 commits into from
Aug 27, 2013

Conversation

pjcozzi
Copy link
Contributor

@pjcozzi pjcozzi commented Aug 23, 2013

@bagnell please review this.

@kring you may want to add this to the inspector at your leisure. #1025

It's cool.

image

/**
* @private
*
* Used for to implement {@see Scene.debugShowFrustums}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Used to.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Aug 26, 2013

Ready for another look.

bagnell added a commit that referenced this pull request Aug 27, 2013
@bagnell bagnell merged commit c0a2f87 into master Aug 27, 2013
@bagnell bagnell deleted the debugfrustum branch August 27, 2013 18:22
/**
* @private
*
* Used to implement {@see Scene.debugShowFrustums}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the doc build because the @ private attribute needs to come after any comments. I fixed it in #1080 since I was already fixing other doc related issues with my pull and that PR should come in tomorrow anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants