-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Matrix Multiplication Shaders #12349
base: main
Are you sure you want to change the base?
Fixed Matrix Multiplication Shaders #12349
Conversation
Thank you for the pull request, @GGajanan1! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
|
Thanks @GGajanan1! I can confirm we have a CLA on file for you now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes so far @GGajanan1!
I think there are a few other places where this update is needed as well:
DepthPlaneVS.glsl
EllipsoidVS.glsl
GlobeVS.glsl
modelToWindowCoordinates.glsl
Description
Fixed Matrix Multiplication in shaders
fixes #4250
Issue number and link
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change