Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splat shader #12364

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Splat shader #12364

wants to merge 44 commits into from

Conversation

keyboardspecialist
Copy link

@keyboardspecialist keyboardspecialist commented Dec 6, 2024 •
edited
Loading

Description

Opening as a draft as some things are still in progress, and this is a long running feature branch.

This adds support for rendering Gaussian splats from 3D Tiles 1.1 using a proposed draft extension here

description in progress

Support added for integer textures with pixel formats R32UI/R32I, RG32UI/RG32I, RGB32UI/RGB32I.

Issue number and link

Testing plan

TBD. Will include a sandcastle.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@keyboardspecialist
initial vertex calcs for splats
0103673
@keyboardspecialist
removed early returns. we seem to hit them all the time
ea53962 
interesting scaling decomposed covariance
@keyboardspecialist
covariance fixes
60022f4 
fragment shader impl
@keyboardspecialist
hack to switch primitive type points to triangle_strips
ba77e31
@keyboardspecialist
refactor, use inverse matrices
8d67853
@keyboardspecialist
final point primitive experiment. moving to quads
9aaf292
@keyboardspecialist
quad drawing.
8c3aea4 
need to get instanced drawarrays working
@keyboardspecialist
new splat pipeline files
7a3f472
@keyboardspecialist
shader org
4f9c886
@keyboardspecialist
switched rendering to not need vertex buffer attr
b235c09
@keyboardspecialist
tweaks
df28196
@keyboardspecialist
detect KHR_gaussian_splatting extension and set props and prime for p…
bdf4eb5 
…ost processing
@keyboardspecialist
Buffer rework. inject attribute buffer for screen space quad at gltf …
7a4c864 
…loading.

Setup for instanced rendering of quads
@keyboardspecialist
splats but bad projection
c6b8d25
@keyboardspecialist
shader cleanup, simplification
a03abdd
@keyboardspecialist
minor tweaks
7d5b09a
@keyboardspecialist
tweaks
0620dca
@keyboardspecialist
Fixed position and color buffers
fe340a4 
Attempting to fix splat scaling
@keyboardspecialist
scaling?
e352ca2
@keyboardspecialist
added new GAUSSIAN_SPLAT pass
3e74c74
@keyboardspecialist
pipeline execution for splats
d5f4069 
new uniforms for camera data, no more computing in vertex shader

renamed splat stage define
@keyboardspecialist
splats sorted via countSort
13dfa78 
some clean up
@keyboardspecialist
invalidates splat commands when camera moves
31e8d13 
correctly uses viewProjection when sorting
@keyboardspecialist
gaurded splat vertex setup in builddrawcommand
947d9e0 
prop cleanup
@keyboardspecialist
command rebuild under control
9862eeb
@keyboardspecialist
guard gaussian pipeline stage
0069114
@keyboardspecialist
sorting fixes
427d490 
shader tweaks
@keyboardspecialist
cleanup
fcfc3df
@keyboardspecialist
opacity fix
f4657c6
@keyboardspecialist
small tweak to re-enable instanceDivisor check on attr 0
2270dae
@keyboardspecialist
splat scale now adjustable with 3DTile style
fb180f6
@keyboardspecialist
toggle between points and splats at runtime
43c08cf
@keyboardspecialist
Merge branch 'main' into splat-shader
2b1e72a
@keyboardspecialist
fixes from latest merge
52b3d61 
updates to load meshopt splats
@keyboardspecialist
shader updates improves performance and visual quality
f207786 
removing legacy _opacity attribute support
@keyboardspecialist
staging for demo
18d75d2
@keyboardspecialist
Add unsigned int pixel datatype
ddceea8
@keyboardspecialist
guassian texture pipeline
d2441cf
@keyboardspecialist
splat index attr
3c7bae6
@keyboardspecialist
splatting texture pipeline updates and improvements
6061b17
@keyboardspecialist
Lots of pipeline changes.
b2f5aa2 
Sorting no longer occurs during the Gaussian texture pipeline.

Texture path shaders simplified and optimized. (Should migrate if attribute pipeline stays).

Migrating to proper task processor workers for sorting and texture generation

Lots of clean up.
@keyboardspecialist
temporary wasm package integration for CI and sandcastle until NPM
361312b
@keyboardspecialist
missing files
1991389
@keyboardspecialist
Rendering fixes and tweaks
baf322d
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited by jjspace
Loading

Thank you for the pull request, @keyboardspecialist! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@ggetz
Copy link
Contributor

ggetz commented Dec 6, 2024

Hi @keyboardspecialist! I can confirm we have a CLA on file for you.

The first step here will be merging in main, which may be a bit more involved since this branch appears to have been created since we last update prettier. To minimize the formatting conflicts, please follow these instructions as part of your process of merging main, and add a comment when this is ready for a look. Thanks!

@ggetz
Copy link
Contributor

ggetz commented Dec 13, 2024

@keyboardspecialist I'm bumping my comment above, as it's preventing us from being able to effectively review this PR. If you have any questions or concerns, please let us know!

Meanwhile, I did leave a review on CesiumGS/cesium-wasm-utils#1, which encapsulates the wasm aspect of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyboardspecialist @ggetz