Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iTwin Geospatial Features API #12449

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jan 23, 2025

Description

  • Adds initial support for the OGC WFS Geospatial Features API through ITwinData.loadGeospatialFeatures
  • Updates the iTwin Feature Service Sandcastle to use the new API

Issue number and link

No issue, follow up for #12344

Testing plan

  • Load the iTwin Feature Service sandcastle and make sure it still works

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz January 23, 2025 17:53
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjspace! Code looks good to me!

It looks like CI is failing, could you please double check that?

packages/engine/Source/Scene/ITwinData.js Outdated Show resolved Hide resolved
@jjspace
Copy link
Contributor Author

jjspace commented Jan 24, 2025

@ggetz fixed, should be good now, silly little issue with too many / with the debug pragma 🤦

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjspace! Code all looks good. I'll merge once we have confirmation about the dataset.

@ggetz
Copy link
Contributor

ggetz commented Jan 30, 2025

@jjspace In the Sandcastle example, could you please update the points id to use 2380dc1b-1dac-4709-aa5c-f6cb38c4e9f5? After that, this should be good to go!

@jjspace
Copy link
Contributor Author

jjspace commented Jan 30, 2025

@ggetz done, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants