Fix DeveloperError when zooming in 2D #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… crash when attempting to normalize the zero vector during translation in 2D.
Conflicts: CHANGES.md
|
Can we add a unit test to verify that this doesn't break again? |
|
@mramato This is ready. |
|
If you use the mouse to zoom-in as close as possible, and then call the camera |
|
That is by design. The |
|
Okay, we can save that discussion for a camera API review further down the line. |
mramato
added a commit
that referenced
this pull request
Feb 10, 2014
Fix DeveloperError when zooming in 2D
mramato
added a commit
that referenced
this pull request
Jun 16, 2014
Chrome Canary recently added `navigator.hardwareConcurrency` which exposes the number of physical cores on the client. This is a simple change to expose that value (or a default if not defined) on `FeatureDetection`. I chose 3 as the fallback because according to Steam's hardware survey (http://store.steampowered.com/hwsurvey/) (2 cpus 47.26% 4 cpus 44.94%) This will be handy when we do #1437 (probably post 1.0), but is useful immediately for `Primitive` creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1432.
Fix developer error when zooming creates an invalid frustum. Also fix crash when attempting to normalize the zero vector during translation in 2D.