Compress Primitive normals #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ats. Removed texture coordinate compression.
|
#2212 Needs to be merged before this. |
| return geometry; | ||
| } | ||
|
|
||
| normals = normals.values; |
There was a problem hiding this comment.
I'm not sure that we should change the variables type like this. I think it will confuse the optimizer - and this is a function we would like the optimizer to do well with for KML loading performance.
Same comment below.
|
Update CHANGES.md. |
| ' czm_non_compressed_main(); \n' + | ||
| '}'; | ||
|
|
||
| return createShaderSource({ sources : [attributeDecl, globalDecl, modifiedVS, compressedMain] }); |
|
This is awesome. Just those trivial comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1628.
Primitive normals are compressed using oct encoding and packed into floats. If the geometry has any combination of the following vertex attributes: texture coordinates, normal, tangent and binormal, they will all be packed into a single vec4 attribute.