Optimize Polygon triangulation #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly exit from return statements).
…he component needed.
… form requiring the slope which breaks down for vertical lines.
|
I suspect you'll get additional peformance gains by removing |
|
For performance, can we look at:
|
|
Also fixes #1089. |
| @@ -512,6 +512,25 @@ define([ | |||
| }; | |||
|
|
|||
| /** | |||
| * The modulo operation that also works for negative dividends. | |||
There was a problem hiding this comment.
Add to CHANGES.md. Once we know the performance gain, we should also mention it.
|
Code looks fine. @bagnell can you also profile this as part of the performance testing? |
|
Total time triangulating in ms.
|
|
CC @DavidHudlow |
|
Very nice. Let's look at subdivision in a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2074.
I still want to look at the performance, but the code can be reviewed. You might want to look at the individual commits before and after the fourth one; I moved all of the functions around so they were defined before they were called.
@pjcozzi This doesn't change the subdivision as we discussed. If its better than how its done now, it'll be in a separate PR.