Optimize Polygon subdivision #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les (avoids many inverse trig calls).
| if (g0 === max) { | ||
| edge = Math.min(triangle.i0, triangle.i1).toString() + ' ' + Math.max(triangle.i0, triangle.i1).toString(); | ||
| edge = Math.min(i0, i1) + ' ' + Math.max(i0, i1); |
There was a problem hiding this comment.
Do you think we would get a performance gain by optimizing this key to avoid the string, e.g., a floating-point value that is min.max or a more efficient data structure than just using a JavaScript object as a hash lookup?
|
@bagnell is there anything else you want to try before we merge. |
|
CC #2179 |
|
We're looking at a new subdivision algorithm, but will merge this improvement in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases performance and reduces memory allocations. The times in the table below are in ms.