Improve extruded polygon and wall performance. #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geometries. Also reduce memory allocations.
…p and remove more temporary object creation.
| * @param {Number} radius The radius of the circle. | ||
| * @returns {Number} The chord length. | ||
| */ | ||
| CesiumMath.chordLength = function(angle, radius) { |
There was a problem hiding this comment.
Unit tests and developer errors.
Could also go in CHANGES.md, but probably not important enough.
|
@pjcozzi This is ready for another look. |
|
Make a note about ideas for the scratch arrays in #2179. |
pjcozzi
added a commit
that referenced
this pull request
Dec 17, 2014
Improve extruded polygon and wall performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only slightly improves the performance. A few percent here and there but not enough to mention numbers. Most of this PR is removing temporary object creation by using scratch variables.