-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fly to data on load #2601
Fly to data on load #2601
Conversation
Also made Cesium Viewer fly to a data source if loaded via url without a lookAt parameter.
Looks good. I'm sure it's not this code, but dragging and dropping I think this could be merged even before fixing flights. |
@emackey, have you had a chance to check this out? If you think it's cool too we should merge it for 1.10, otherwise we can hold off until flights are better. |
return flyToOnDrop; | ||
}, | ||
set : function(value) { | ||
flyToOnDrop = value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we do this, as opposed to having a simple property, or knockout? Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like proxy and clearOnDrop are simple get/set as well, so I was most likely just following suit. I'm not sure why they are though, so I'll change them and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I had a suspicion the reason was jsDoc and I was right. For some reason assigning the value directly to viewer and documenting it causes it not to show up in the doc. So we'll just leave it the way it is for now.
I like the behavior of this, and I think we should merge for 1.10. I'll second @pjcozzi's comment about |
Maybe the |
Unfortunately not.
|
I'm not sure what you mean. I thought that feature continually updates the URL as the view changes. So when it flies to the data, the url reflects the new view. |
Here's a link that in master will show you Wallops Island, not the South pole:
|
Basically, if the |
Yeah, I noticed what you mean, I'm fixing it now. |
Should be ready. |
Flights and bounding sphere issues aside, this behavior is better than master. Tests pass. Merging. |
I don't want this merged any time soon, but please play with this and provide feedback
This is a simple 2 file change that builds on #2600 (once that is merged, this PR will be tiny). It does 2 things.
viewerDragDropMixin.flyToOnDrop
(on by default) which causes viewer to fly to a data source when it is dropped onto the globe, similar to Google Earth.This functionality actually works really well, but has a few minor drawbacks: