Polygonidl #720
Merged
Polygonidl #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p 3x. We need to take a closer look.
Conflicts: CHANGES.md Source/Core/IntersectionTests.js Source/Core/PolylinePipeline.js Specs/Core/IntersectionTestsSpec.js
Conflicts: Source/Core/EllipsoidTangentPlane.js Source/Core/Plane.js Specs/Core/PlaneSpec.js
| // Append two new points, the intersection points of the | ||
| // triangle edges and the plane. | ||
|
|
||
| // TODO: raise to surface in plane |
There was a problem hiding this comment.
Remove this comment. Since we subdivide and raise to the surface afterward, we don't have to do anything here.
relocated function to offset triangles from the IDL to be a private function in PolygonPipeline.js added tests for wrapLongitude updated CHANGES.md
|
@pjcozzi I think I've fixed everything you mentioned above, except for optimizing the split triangle function (i'm still thinking on that) and adding an example to |
|
It looks like you need to merge master down into this branch and merge some conflicts. |
Conflicts: CHANGES.md
| @@ -45,7 +45,9 @@ Beta Releases | |||
| * Improved rendering performance by minimizing WebGL state calls. | |||
| * Fixed an error in Web Worker creation when loading Cesium.js from a different origin. | |||
| * Fixed `EllipsoidPrimitive` picking and picking objects with materials that have transparent parts. | |||
| * Fixed imagery smearing artifacts on mobile devices and other devices without high-precision fragment shaders. | |||
| * Fixed imagery smearing artifacts on mobile devices and other devices without high-precision fragment shaders.* Added `IntersectionTests.trianglePlaneIntersection`. | |||
| * Added `IntersectionTests.trianglePlaneIntersection`. | |||
There was a problem hiding this comment.
Sorry, we should move these to a new section for b17 since b16 is already done.
added 7 commits
May 6, 2013 09:14
other minor changes
check if bounding sphere of polygon is in x < 0 undo changes accidentally checked in to Polygons.html
|
Code looks good. Tests pass. Coverage is good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subdivides triangles that intersect with the international date line into three triangles that don't intersect. Moves points on the IDL away by 1e-11.