Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cesiumWorkerBootstrapper.js #9573

Closed
wants to merge 1 commit into from

Conversation

CraigPatakyEDX
Copy link

Proposed change enables Cesium to work with Electron. Alters scope of variables: requirejs, require, define

This takes care of an issue as noted by Stuart Attenborrow in 2018.

See at: https://community.cesium.com/t/fixing-cesiumworkerbootstrapper-when-using-electron-react-webpack/6532

Proposed change enables Cesium to work with Electron.  Alters scope of variables: requirejs, require, define

This takes care of an issue as noted by Stuart Attenborrow in 2018.  

See at: https://community.cesium.com/t/fixing-cesiumworkerbootstrapper-when-using-electron-react-webpack/6532
@cesium-concierge
Copy link

cesium-concierge commented May 28, 2021

Thank you so much for the pull request @CraigPatakyEDX! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@cesium-concierge
Copy link

Thanks again for your contribution @CraigPatakyEDX!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@CraigPatakyEDX
Copy link
Author

CraigPatakyEDX commented Aug 27, 2021 via email

@ggetz
Copy link
Contributor

ggetz commented Jan 19, 2022

Thanks for the PR @CraigPatakyEDX. In order to merge you're fix, you need to do a few things:

  1. Send in a Contributor License Agreement (CLA)
  2. Add your name to the contributors file
  3. Update CHANGES.md with a brief description of your fix.

@ebogo1 As of #9718, nothing else is blocking this fix from going in, correct?

@ggetz
Copy link
Contributor

ggetz commented Jan 20, 2022

Actually, taking a closer look at this, this does not have anything to do with #9718.

The line altered is part of a verbatim copy of requireJS, and should not be modified. I do believe that there may be a fix needed or further configuration to get Cesium to play nicely with Electron across the board, however I don't think this is the right way to go about it. @CraigPatakyEDX If you're still interested in addressing the cause please open an issue with more details on how to replicate, and we can figure out the best way to resolve it.

@ggetz ggetz closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

3 participants