Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #9473. Uses the npm module for meshoptimizer instead of storing the files in the repo. This change does not appear to affect build size (as expected, since only the decoder is included in the import).
This also fixes #9751, but I'm not sure where the
console.warn
call came from - the code insideif (WebAssembly.validate(detector)) { ... }
still gets hit, but on the npm version there's no warning message. Was the warning part of an older release of meshopt (cc @sanjeetsuhag)? This shouldn't be an issue but I thought I'd make note of it.Tested in Sandcastle with these changes merged into
model-experimental-meshopt
. I pushed the merge to that branch.(edit my comment to see the local Sandcastle.. I think the link is too big to use regular formatting)