Dont optimize without indices #155
Conversation
| }; | ||
| expect(function() { | ||
| cacheOptimization(gltf); | ||
| }).not.toThrowRuntimeError(); |
There was a problem hiding this comment.
Is there a better way to test this, since we don't actually throw RuntimeErrors in gltf-pipeline.
There was a problem hiding this comment.
I just checked and this doesn't fail without the changes, so you're right, we need a better test here.
|
Updated |
| } | ||
| } | ||
| }; | ||
| cacheOptimization(gltf); |
There was a problem hiding this comment.
You should have at least one expect in here. Maybe just create a spy for GeometryPipeline.reorderForPostVertexCache and check that it's not called.
There was a problem hiding this comment.
Oh well I guess that would pass for both...
There was a problem hiding this comment.
No, that should work. gltfPrimitiveToCesiumGeometry would work too.
|
Updated |
|
Sorry just had a last minute thought, can you update CHANGES.md with the change? We should start getting in the habit of this now. |
|
Yup |
Fixes #154, @lilleyse, could you look at this when you get a chance?