Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch v0.1 #36

Merged
merged 26 commits into from
Jun 8, 2018
Merged

Patch v0.1 #36

merged 26 commits into from
Jun 8, 2018

Conversation

ChacaS0
Copy link
Owner

@ChacaS0 ChacaS0 commented May 30, 2018

No description provided.

ChacaS0 and others added 10 commits March 25, 2018 14:25
 On branch devel
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/list_test.go
	modified:   cmd/rm_test.go
	modified:   cmd/start_test.go
* ✔️ Mispells fixes

 On branch devel
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/list_test.go
	modified:   cmd/rm_test.go
	modified:   cmd/start_test.go

* 🚧 Work on rework of rm command starts -- bad

 Issues related:
 	-> #21 Improve ``rm`` command

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go

* 💊 Fixed missspelling

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* ✔️🏁 processArgsRm added + tests

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* ✔️🏁 New feature for rm
	-> Added & adapted tests only for the ones impacted by those changes

 Issues related:
 	-> #21
 	-> #16

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go

* 💻🏁 Added test for rm.go:simpleDelAllString()
	-> Few changes (variadic params instead of slice)
	-> Some update for the ``$HOME`` on Windows

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/purge.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go

* ✔️🏁 Added handler for ``*`` wildcard as argument
	-> Tests, were adapted for that

 Issues related:
 	-> #21

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* 📝 Update of usage for ``rm`` and deletion of deprecated stuff

 Issues related:
 	-> #21
 	-> #19

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
* 🚧 Added the functionality, now needs the tests

 Issues related:
 	-> #20

* 🏁 Tests for list.go (``--fix`` flag related)
	+ Begin of migration to the use of Target instead of simple strings

 Issues related:
 	-> #20

-----------------------
Merge Fixes #20
* 🚧 Moved configs files for TEMpest into a directory
	[+] Added .sh for auto-mode
	--> Issues related: #24, #15
* Handler for shutup mode made, need merge
* Stash pop
* 🏁 Added tests for shutup mode handler (start.go)
	-> Issues related: #15, #16
* ✔️🏁 Added logs flag for get command
	[+] Added the corresponding test
	--> Issues related: #15, #16
* ✔️ Added handler for relative paths with ``add``
* 🏁 Added tests for treatRelativePath()
* 🏁 Test for getAllLogs() (--logs)
	--> Issues related: #15, #16
	[*] Should be the end of the Linux part for this one
* 💻 Windows autostart kinda done for theoric part
	[#] Issues related: #15, #9
	[T] Unit tests for set.go:setAutoStart()
	[T] Runtime testing for Windows
* 📛 Hot fix for codecov chmod
* 🏁 Test only for error checks
	[I] #15, #16
	[T] More elaborated tests for setAutoStart()
	[#] Fixes #15
	[+] Also implemented test func for it
	[#] Issues: #15, #16
* 🚧 Started to refractor purge to purge files
	[T] Keep refratoring each functions affected
	[#] Issues: #17
	[N] Some comments were deleted (cobra related)

* New func to display size + units

* 📄🚽 Implemented the file purging
	[T] Tests
	[#] #30, #17

* 🏁 Tests for purge
👉 Apply TreatLastChar() to conf.Gobin & conf.Gopath
* ✔️ Func to find dirs from exact pattern added

* ✔️ Flag on ``add`` command added
🏁 Test for the research func
	[T]	Test the other funcs created

* ✔️ Better error handling for that
👉 TODO? More interaction for this command/flag

* ✔️ command ``new`` implemented to generated new target dirs
🏁 Tests passed
@ChacaS0 ChacaS0 added bug Something isn't working enhancement Improvement of existing feature build Build related linux linux related stuff windows windows related stuff feature For a new feature labels May 30, 2018
@ChacaS0 ChacaS0 added this to the v0.1 milestone May 30, 2018
@ChacaS0 ChacaS0 self-assigned this May 30, 2018
@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #36 into master will decrease coverage by 0.93%.
The diff coverage is 44.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   46.72%   45.79%   -0.94%     
==========================================
  Files          12       14       +2     
  Lines         901      998      +97     
==========================================
+ Hits          421      457      +36     
- Misses        431      484      +53     
- Partials       49       57       +8
Impacted Files Coverage Δ
cmd/rm.go 60.68% <ø> (ø) ⬆️
cmd/purge.go 27.1% <0%> (-0.52%) ⬇️
cmd/start.go 52.27% <0%> (ø) ⬆️
cmd/init.go 29.11% <0%> (-2.4%) ⬇️
cmd/set.go 39.77% <100%> (ø) ⬆️
cmd/add.go 57.5% <41.86%> (-12.88%) ⬇️
cmd/new.go 52.94% <52.94%> (ø)
cmd/root.go 56.38% <60%> (-1.09%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ca504...c4bac81. Read the comment docs.

ChacaS0 and others added 5 commits June 7, 2018 15:54
*  Added fallback to cmd.Help() by default

* ✔️ add

* ✔️ init

* ✔️ new
✅ fix init

* ✔️ purge

* ✔️ rm

* ✔️ root

* ✔️ set

* ✔️ start
👉 the rest can wait :(

* 👍 Small update to README.md

* messing
@ChacaS0 ChacaS0 merged commit 76f2192 into master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build related enhancement Improvement of existing feature feature For a new feature linux linux related stuff windows windows related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant