Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add node v20 support #102

Merged
merged 3 commits into from
Jun 3, 2023
Merged

chore: add node v20 support #102

merged 3 commits into from
Jun 3, 2023

Conversation

wemeetagain
Copy link
Member

No description provided.

@wemeetagain wemeetagain requested a review from a team as a code owner May 30, 2023 18:19
@dapplion
Copy link
Contributor

Some CI for v20 is broken

Main / build-arm (20) (pull_request)
Main / build (ubuntu-20.04, 20) (push)

@wemeetagain
Copy link
Member Author

Seems it is flaky. Rerunning fixes it

@dapplion
Copy link
Contributor

dapplion commented Jun 1, 2023

Tho why is arm arch so flaky too? On master everything is green

@wemeetagain
Copy link
Member Author

Old versions were failing due to relying on old unsupported versions of debian.

I've removed support for them.

@dapplion
Copy link
Contributor

dapplion commented Jun 2, 2023

arm v20 is failing, I would drop support for it in this PR to unlock other archs and debug latter

@wemeetagain
Copy link
Member Author

its also failing in non-arm ubuntu ???

frustratingly, its not failing locally
and seeing the error, its hard to see how it could go so wrong... https://github.com/ChainSafe/blst-ts/actions/runs/5147380281/jobs/9286645208?pr=102

it's failing to do string equality?!
https://github.com/ChainSafe/blst-ts/blob/6ff826db02a1c5363d30e67785742b85c9172dea/test/spec/index.test.ts#LL137C16-L137C36

@wemeetagain
Copy link
Member Author

Its all passing.... just quite flaky

@wemeetagain wemeetagain merged commit 0b98c8a into master Jun 3, 2023
@wemeetagain wemeetagain deleted the cayman/node-20 branch June 3, 2023 18:04
matthewkeil pushed a commit that referenced this pull request Mar 28, 2024
@wemeetagain @matthewkeil
chore: add node v20 support (#102)
6d11203 
* chore: add node v20 support

* chore: remove old unsupported versions

* Remove reference to node v12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wemeetagain @dapplion