-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: napi-rs binding #149
Conversation
this is amazing ❤️ , would be great if you can add a Readme on how to setup environment, build and run tests @wemeetagain |
You will need https://rustup.rs/ installed. Also very recommended to have rust extensions in vscode. This branch currently only adds code so that side-by-side benchmarks can be run, with the napi-rs version running alongside the existing 0.2.x branch. All new code is in the To build the bindings, run To run a benchmark, first build all the bindings (both napi-rs and 0.2.x), then run from the root: |
Edit: node 22.5.0 broke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the test/utils/multithreading
folder and the tests that use it until we get the multithreading working again. Can always checkout from v1.X branch when we are ready. Can also remove setting UV_THREADPOOL_SIZE
in the package.json test:perf
script.
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: Matthew Keil <me@matthewkeil.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! You 🪨 thoroughly dude! 😎 🥷
Roughly equivalent rewrite of the v0.2.x branch using napi-rs and the
blst
crateKey differences:
agregateWithRandomness
functionResults are promising. This is a comparison between 0.2.x branch and this branch (labeled
- next
)