Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: A more robust check for rinfo.family #178

Merged
merged 2 commits into from
May 12, 2022
Merged

fix: A more robust check for rinfo.family #178

merged 2 commits into from
May 12, 2022

Conversation

dadepo
Copy link
Contributor

@dadepo dadepo commented May 11, 2022

Closes #176

@dadepo dadepo requested a review from a team as a code owner May 11, 2022 20:57
@dadepo dadepo requested a review from wemeetagain May 11, 2022 20:57
@dadepo dadepo changed the title A more robust check for rinfo.family fix: A more robust check for rinfo.family May 11, 2022
@dadepo dadepo force-pushed the dadepo/robust-rinfo-family-check branch from f620185 to 243a8cd Compare May 11, 2022 22:39
dapplion
dapplion approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve the PR but have no way to verify it's correct since I don't own a MacOS. Could you look into adding macos tests to demostrate correctness? Github actions have runners for it I think

@dadepo
Copy link
Contributor Author

dadepo commented May 12, 2022

Could you look into adding macos tests to demostrate correctness? Github actions have runners for it I think

I checked, github actions do support MacOS but unfortunately M1 is still in currently in public beta. See

But the main issue seems to be mainly about node version 18. I updated the version in another branch that does not have the fix and was able to confirm the tests fails. See

Updated the same version in this PR, and all tests passes. See.

So PR should be good to merge.

@dadepo dadepo mentioned this pull request May 12, 2022
Closed
@dapplion dapplion merged commit 7331fbc into master May 12, 2022
@dapplion dapplion deleted the dadepo/robust-rinfo-family-check branch May 12, 2022 11:39
@mpetrunic
Copy link
Member

Could you look into adding macos tests to demostrate correctness? Github actions have runners for it I think

I checked, github actions do support MacOS but unfortunately M1 is still in currently in public beta. See

But the main issue seems to be mainly about node version 18. I updated the version in another branch that does not have the fix and was able to confirm the tests fails. See

Updated the same version in this PR, and all tests passes. See.

So PR should be good to merge.

I can run it locally on m1 if you are concerned

@github-actions github-actions bot mentioned this pull request May 12, 2022
Merged
@dadepo
Copy link
Contributor Author

dadepo commented May 12, 2022

I can run it locally on m1 if you are concerned

Thanks! 🙏 But that should not be needed anymore. Plus I do have an M1 and was able to verify the issue/fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@wemeetagain wemeetagain Awaiting requested review from wemeetagain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have a more robust check for rinfo.family
3 participants
@dadepo @mpetrunic @dapplion