chore: Bump peer-id dep to latest #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
changed the title
|
@wemeetagain any concerns? Otherwise looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping this dependency upgrades several transitive dependencies down the dependency tree (notable
libp2p/cryptowhich in turn switches from the deprecatednoble-secp256k1to the updated/namespaced@noble/secp256k1). The only potentially impactful breaking change here ispeer-idv0.16.0 requires Node v15+. We've been using this version ofpeer-idin theportalnetworkmodule for a while now with no ill effects and I'd like to remove the deprecatednoble-secp256k1module from our dependency tree.