Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify block_cid #142

Merged
merged 4 commits into from
Jan 11, 2022
Merged

verify block_cid #142

merged 4 commits into from
Jan 11, 2022

Conversation

willeslau
Copy link
Contributor

Changes

  • ensure the block cid is verified in verify_*

Tests

cargo test

Issues

@willeslau willeslau requested a review from mattsse January 6, 2022 08:28
@clearloop
Copy link
Contributor

clearloop commented Jan 7, 2022

https://status.node.glif.io/

we can comment off

fn test_http_request() {
momentary here, it works on my local machine, not sure what happens in the CI and the http request get failed, I'll make another PR to show the error detail of the http request since here we need to verify the template node endpoint and our data structure can parse the filecoin API

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! but would like to see some additional docs for pub functions

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@willeslau willeslau merged commit bf06a92 into main Jan 11, 2022
@willeslau willeslau deleted the issue-140 branch January 11, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants