Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl EthGetTransactionByHashLimited #4774

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Sep 18, 2024

Summary of changes

Changes introduced in this pull request:

  • Impl Filecoin.EthGetTransactionByHashLimited and add test
| RPC Method                                | Forest | Lotus |
|-------------------------------------------|--------|-------|
| Filecoin.EthGetTransactionByHashLimited   | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4703

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank marked this pull request as ready for review September 19, 2024 05:17
@sudo-shashank sudo-shashank requested a review from a team as a code owner September 19, 2024 05:17
@sudo-shashank sudo-shashank requested review from ruseinov and elmattic and removed request for a team September 19, 2024 05:17
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
@ruseinov
Copy link
Contributor

The CI needs to be green, then we're ready to rumble.

@sudo-shashank
Copy link
Contributor Author

@ruseinov and @elmattic this PR is ready for review

@elmattic elmattic added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 0832aae Sep 23, 2024
32 checks passed
@elmattic elmattic deleted the shashank/EthGetTransactionByHashLimited branch September 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EthGetTransactionByHashLimited
4 participants