Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement EthGetBlockReceiptsLimited RPC method #5018

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

virajbhartiya
Copy link
Contributor

@virajbhartiya virajbhartiya commented Nov 28, 2024

Summary of changes

Changes introduced in this pull request:

implemented EthGetBlockReceiptsLimited RPC method

Reference issue to close (if applicable)

Closes #5017

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@virajbhartiya virajbhartiya requested a review from a team as a code owner November 28, 2024 13:53
@virajbhartiya virajbhartiya requested review from lemmih and sudo-shashank and removed request for a team November 28, 2024 13:53
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
@elmattic
Copy link
Contributor

Also don't duplicate all the method body: EthGetBlockReceipts and EthGetBlockReceiptsLimited should share common code.

Check out how this is done for other XXXLimited methods.

@elmattic
Copy link
Contributor

Change checklist: Make sure to ✔️ each checkbox.

src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
virajbhartiya and others added 4 commits November 28, 2024 21:35
Co-authored-by: hanabi1224 <harlowmoo@gmail.com>
Co-authored-by: hanabi1224 <harlowmoo@gmail.com>
Co-authored-by: hanabi1224 <harlowmoo@gmail.com>
@elmattic
Copy link
Contributor

elmattic commented Nov 28, 2024

Also, remember to include the issue number being closed after Closes in the Reference issue to close (if applicable) section.

@virajbhartiya
Copy link
Contributor Author

Updated the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filecoin.EthGetBlockReceiptsLimited
3 participants