Skip to content

Commit

Permalink
chore: remove useless comments
Browse files Browse the repository at this point in the history
  • Loading branch information
EclesioMeloJunior committed Dec 6, 2022
1 parent 475d366 commit 23b5ca3
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions lib/grandpa/grandpa.go
Original file line number Diff line number Diff line change
Expand Up @@ -901,8 +901,6 @@ func (s *Service) getPossibleSelectedBlocks(stage Subround, threshold uint64) (m
return nil, err
}

// TODO: if a block reaches enough threshold then should we
// return from here since the others didn't reach the same amount of votes
if total > threshold {
blocks[v.Hash] = v.Number
}
Expand All @@ -925,9 +923,6 @@ func (s *Service) getPossibleSelectedBlocks(stage Subround, threshold uint64) (m
}
}

// we should check if the blocks map contains only
// one element, meaning that one common ancestor
// was found otherwise return an error
return blocks, nil
}

Expand All @@ -949,8 +944,6 @@ func (s *Service) getPossibleSelectedAncestors(votes []Vote, curr common.Hash,
return nil, err
}

// if the common ancestor is the same as
// the current block, should we just continue?
if pred == curr {
return selected, nil
}
Expand Down

0 comments on commit 23b5ca3

Please sign in to comment.