Apply self-review feedback

ChainSafe · Nov 23, 2022 · 4e60257 · 4e60257
1 parent de33406
commit 4e60257
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/lib/runtime/storage/trie.go b/lib/runtime/storage/trie.go
@@ -193,7 +193,7 @@ func (s *TrieState) DeleteChildLimit(key []byte, limit *[]byte) (
 	if limit == nil {
 		err = s.t.DeleteChild(key)
 		if err != nil {
-			return 0, false, err
+			return 0, false, fmt.Errorf("deleting child trie: %w", err)
 		}
 
 		return qtyEntries, true, nil
@@ -212,7 +212,7 @@ func (s *TrieState) DeleteChildLimit(key []byte, limit *[]byte) (
 		// values within the tries, which is used for online pruning.
 		err = tr.Delete([]byte(k))
 		if err != nil {
-			return deleted, allDeleted, fmt.Errorf("deleting from child trie at key 0x%x: %w", key, err)
+			return deleted, allDeleted, fmt.Errorf("deleting from child trie located at key 0x%x: %w", key, err)
 		}
 
 		deleted++
@@ -247,7 +247,7 @@ func (s *TrieState) ClearPrefixInChild(keyToChild, prefix []byte) error {
 
 	err = child.ClearPrefix(prefix)
 	if err != nil {
-		return fmt.Errorf("clearing prefix in child trie at key 0x%x: %w", keyToChild, err)
+		return fmt.Errorf("clearing prefix in child trie located at key 0x%x: %w", keyToChild, err)
 	}
 
 	return nil

diff --git a/lib/trie/child_storage.go b/lib/trie/child_storage.go
@@ -30,7 +30,7 @@ func (t *Trie) PutChild(keyToChild []byte, child *Trie) error {
 
 	err = t.Put(key, childHash.ToBytes())
 	if err != nil {
-		return fmt.Errorf("putting child trie root hash %s in main trie: %w", childHash, err)
+		return fmt.Errorf("putting child trie root hash %s in trie: %w", childHash, err)
 	}
 
 	t.childTries[childHash] = child
@@ -65,7 +65,7 @@ func (t *Trie) PutIntoChild(keyToChild, key, value []byte) error {
 
 	err = child.Put(key, value)
 	if err != nil {
-		return fmt.Errorf("putting into child trie at key 0x%x: %w", keyToChild, err)
+		return fmt.Errorf("putting into child trie located at key 0x%x: %w", keyToChild, err)
 	}
 
 	childHash, err := child.Hash()
@@ -103,7 +103,7 @@ func (t *Trie) DeleteChild(keyToChild []byte) (err error) {
 
 	err = t.Delete(key)
 	if err != nil {
-		return fmt.Errorf("deleting child trie at key 0x%x: %w", key, err)
+		return fmt.Errorf("deleting child trie located at key 0x%x: %w", keyToChild, err)
 	}
 	return nil
 }
@@ -120,7 +120,7 @@ func (t *Trie) ClearFromChild(keyToChild, key []byte) error {
 
 	err = child.Delete(key)
 	if err != nil {
-		return fmt.Errorf("deleting from child trie at key 0x%x: %w", keyToChild, err)
+		return fmt.Errorf("deleting from child trie located at key 0x%x: %w", keyToChild, err)
 	}
 
 	return nil

diff --git a/lib/trie/trie.go b/lib/trie/trie.go
@@ -777,8 +777,6 @@ func (t *Trie) ClearPrefixLimit(prefixLE []byte, limit uint32) (
 	root, deleted, _, allDeleted, err := t.clearPrefixLimitAtNode(
 		t.root, prefix, limit, pendingDeletedMerkleValues)
 	if err != nil {
-		// Note: no need to wrap the error really since the private function has
-		// the same name as the exported function `ClearPrefixLimit`.
 		return 0, false, err
 	}
 	t.root = root