Add missing test database close calls

ChainSafe · Jan 9, 2023 · 948fac0 · 948fac0
1 parent 573d0e9
commit 948fac0
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 5 deletions.
diff --git a/dot/node_integration_test.go b/dot/node_integration_test.go
@@ -216,6 +216,8 @@ func TestInitNode_Integration(t *testing.T) {
 	})
 	require.NoError(t, err)
 	require.NotNil(t, db)
+	err = db.Close()
+	require.NoError(t, err)
 }
 
 func TestInitNode_GenesisSpec(t *testing.T) {
@@ -233,6 +235,8 @@ func TestInitNode_GenesisSpec(t *testing.T) {
 	})
 	require.NoError(t, err)
 	require.NotNil(t, db)
+	err = db.Close()
+	require.NoError(t, err)
 }
 
 func TestNodeInitializedIntegration(t *testing.T) {

diff --git a/dot/state/storage_test.go b/dot/state/storage_test.go
@@ -173,6 +173,10 @@ func TestGetStorageChildAndGetStorageFromChild(t *testing.T) {
 		DataDir: filepath.Join(basepath, "db"),
 	})
 	require.NoError(t, err)
+	t.Cleanup(func() {
+		err = db.Close()
+		require.NoError(t, err)
+	})
 
 	_, genTrie, genHeader := newTestGenesisWithTrieAndHeader(t)
 

diff --git a/lib/babe/verify_integration_test.go b/lib/babe/verify_integration_test.go
@@ -532,6 +532,10 @@ func TestVerifyForkBlocksWithRespectiveEpochData(t *testing.T) {
 		InMemory: true,
 	})
 	require.NoError(t, err)
+	t.Cleanup(func() {
+		err := inMemoryDB.Close()
+		require.NoError(t, err)
+	})
 
 	const epochPrefix = "epoch"
 	epochStateDatabase := chaindb.NewTable(inMemoryDB, epochPrefix)

diff --git a/lib/runtime/wasmer/imports_test.go b/lib/runtime/wasmer/imports_test.go
@@ -11,7 +11,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/ChainSafe/chaindb"
 	"github.com/ChainSafe/gossamer/lib/common"
 	"github.com/ChainSafe/gossamer/lib/common/types"
 	"github.com/ChainSafe/gossamer/lib/crypto"
@@ -1793,10 +1792,7 @@ func Test_ext_trie_blake2_256_root_version_1(t *testing.T) {
 func Test_ext_trie_blake2_256_verify_proof_version_1(t *testing.T) {
 	t.Parallel()
 
-	memdb, err := chaindb.NewBadgerDB(&chaindb.Config{
-		InMemory: true,
-	})
-	require.NoError(t, err)
+	memdb := newDatabase(t)
 
 	otherTrie := trie.NewEmptyTrie()
 	otherTrie.Put([]byte("simple"), []byte("cat"))

diff --git a/lib/trie/database_test.go b/lib/trie/database_test.go
@@ -17,6 +17,10 @@ func newTestDB(t *testing.T) chaindb.Database {
 	}
 	database, err := chaindb.NewBadgerDB(chainDBConfig)
 	require.NoError(t, err)
+	t.Cleanup(func() {
+		err := database.Close()
+		require.NoError(t, err)
+	})
 	return chaindb.NewTable(database, "trie")
 }
 

diff --git a/lib/trie/proof/proof_test.go b/lib/trie/proof/proof_test.go
@@ -37,6 +37,11 @@ func Test_Generate_Verify(t *testing.T) {
 		InMemory: true,
 	})
 	require.NoError(t, err)
+	t.Cleanup(func() {
+		err := database.Close()
+		require.NoError(t, err)
+	})
+
 	err = trie.WriteDirty(database)
 	require.NoError(t, err)