Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency inject databases and tables #2981

Closed
qdm12 opened this issue Nov 29, 2022 · 1 comment
Closed

Dependency inject databases and tables #2981

qdm12 opened this issue Nov 29, 2022 · 1 comment
Assignees
Labels
A-triage issue description needs refactor and/or labeled.

Comments

@qdm12
Copy link
Contributor

qdm12 commented Nov 29, 2022

In many places we create the database or the table in constructors (or even worst in Start methods), whereas it should ideally be injected as dependency instead.

This blocks some modifications such as using a database in the trie code, or creates duplicate table objects which may or may not be thread safe. It also makes changing our database implementation harder.

@timwu20
Copy link
Contributor

timwu20 commented Jun 7, 2024

Completed in #3434

@timwu20 timwu20 closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-triage issue description needs refactor and/or labeled.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants