Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/runtime: implement ext_network_state #1108

Merged
merged 7 commits into from
Sep 28, 2020
Merged

lib/runtime: implement ext_network_state #1108

merged 7 commits into from
Sep 28, 2020

Conversation

edwardmack
Copy link
Member

@edwardmack edwardmack commented Sep 23, 2020 •
edited
Loading

Changes

  • Implement function ext_network_state

Tests

go test ./lib/runtime/...

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

noot
noot reviewed Sep 23, 2020
View reviewed changes
dot/core/service.go Outdated Show resolved Hide resolved
noot
noot approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

noot
noot reviewed Sep 23, 2020
View reviewed changes
lib/runtime/test_helpers.go Outdated Show resolved Hide resolved
@edwardmack edwardmack merged commit 2615560 into development Sep 28, 2020
@edwardmack edwardmack deleted the ed/ext_network_state branch September 28, 2020 15:04
@edwardmack edwardmack self-assigned this Oct 1, 2020
This was referenced Oct 19, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot approved these changes

Assignees

@edwardmack edwardmack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardmack @noot