Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dot): Closes db if node initialized check fails #1551

Merged
merged 6 commits into from
May 4, 2021
Merged

fix(dot): Closes db if node initialized check fails #1551

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ee35c9
chore: closes db if node initialized check fails
EclesioMeloJunior Apr 30, 2021
d651b51
Merge branch 'development' into fix/closes-db-node-initialized-check-err
noot Apr 30, 2021
65e4189
Merge branch 'development' into fix/closes-db-node-initialized-check-err
noot Apr 30, 2021
6c9e95e
Merge branch 'development' into fix/closes-db-node-initialized-check-err
noot May 4, 2021
28790ef
Merge branch 'development' into fix/closes-db-node-initialized-check-err
noot May 4, 2021
2e10b70
Merge branch 'development' into fix/closes-db-node-initialized-check-err
noot May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions dot/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ func NodeInitialized(basepath string, expected bool) bool {
return false
}

defer func() {
// close database
err = db.Close()
if err != nil {
logger.Error("failed to close database", "error", err)
}
}()

// load genesis data from initialised node database
_, err = state.NewBaseState(db).LoadGenesisData()
if err != nil {
Expand All @@ -164,12 +172,6 @@ func NodeInitialized(basepath string, expected bool) bool {
return false
}

// close database
err = db.Close()
if err != nil {
logger.Error("failed to close database", "error", err)
}

return true
}

Expand Down