-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dot/state, lib/babe, lib/trie): improve syncing between gossamer authority nodes #1613
Merged
Merged
Changes from 84 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
5a38145
update README.md
noot 117ebb8
update docs
noot c834e99
update gssmr genesis file to have 6 auths
noot 2fca3d8
Merge branch 'development' into noot/update-readme
noot 70b794e
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot b5ba601
add peercount to network logs
noot 02faa96
update log order
noot 09e8ca9
Merge branch 'development' into noot/update-readme
dutterbutter 2943b15
Merge branch 'noot/devnet' of github.com:ChainSafe/gossamer into noot…
noot 5d09224
update logs
noot d6e13f8
add log
noot 332ff24
change DHT mode to ModeServer, add peersToTry map
noot c2175f5
lint
noot 4f35500
fix loop logic in beginDiscovery
noot e0dce6a
add advertising logic
noot 6246ce1
lint
noot 65a021b
increase intial advertise ttl
noot e4417e4
bootstrap dht before advertise
noot f444e14
fix
noot d78eaa8
add discovery submodule; wait for peers before starting DHT
noot f67be8a
add logs
noot 2578344
add package to get public IP
noot bc808a5
add routing table refresh
noot 2233927
remove routing table refresh
noot 1b87f0d
fix some tests
noot 0525703
remove advertisement
noot 63709f6
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 1f91b09
readd advertisement
noot acb5df1
cleanup
noot 0960e47
revert genesis files
noot d984743
re-enable test
noot d3e47c0
update log levels
noot 46bdf5c
decrease time before advertising
noot 453660b
restore bootstrap order
noot 47899b2
decrease failed to advertise ttl
noot 62d9f28
cleanup, add constants
noot 92bac0c
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 9dc4efb
log cleanup
noot 49781d9
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 165743e
update runtime c=3/4 (1/4 probability of empty slot)
noot 314071d
update gossamer genesis.json
noot c93bcab
merge w fix-discovery
noot 50926ed
merge w development
noot 326d8dc
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 7f3a59f
update to 3 auth genesis
noot 7ed2854
pause BABE when syncing
noot 1df3929
check err
noot d7fcbbb
send block response even if missing some data
noot 3e1d662
restore 6 auths in genesis for babe
noot caf07cf
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 320bae5
add snapshot in StorageState.StoreTrie
noot 2abd107
cleanups
noot 6d01dcd
cleanup
noot 0bb1c5b
lock StoreTrie the whole time
noot 9d220a7
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 01bd01c
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot ed05cb7
add go.mod
noot ad8d48d
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 5fa2a7e
merge w development
noot 3057240
add state logs
noot 42ff15e
add state logs
noot 7a7f294
fix
noot 65e1e45
update trie.Snapshot to return new trie
noot f9d04f2
fix
noot c53b174
update tests for updated trie.Snapshot
noot b7bf025
lint
noot 52cc4a6
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 4623d7a
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 3706836
decrease connectToPeersTimeout
noot edd142e
change log lvl for handshakes
noot 3b330f7
fix sendData to use correct handshakeDecoder
noot 5d52006
add logs, try to fix sigabrt
noot 8d60ef2
add logs, try to fix sigabrt
noot 214784c
add nil checks
noot 7c4cd23
add log
noot ab21bb8
add log
noot 5bfb710
slightly increase sleep in attemptToFinalize
noot c52ddaf
Merge branch 'noot/fix-devnet-sync' of github.com:ChainSafe/gossamer …
noot 151ff95
update babe locks
noot 4df4c10
remove changes except trie.Snapshot update
noot e4d3762
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 89f944b
fix
noot 69bcc45
cleanup
noot 291588e
fix
noot 19cc490
Merge branch 'development' into noot/fix-devnet-sync
noot 94e69b2
Merge branch 'development' into noot/fix-devnet-sync
noot 9a848bd
remove network sleep
noot 480b57d
increase test timeout in makefile
noot 146813f
skip stalling test
noot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s.oldTrie
points to the same ref ass.t
ands.t
points to the created snapshot, if I'm not wrong, any modifications ins.t
will modify thes.oldTrie
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does, but in the following line
s.t
gets snapshotted, sos.oldTrie
won't be modified ifs.t
is modified when this function completes.s.oldTrie
is effectively a pointer to the root of the previous trie, ands.t
becomes a pointer to the root of the working trieThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! just
s.t
changes the ref,s.oldTrie
keeps pointing to the old, nice! Why not just keeps.oldTrie = s.t.Snapshot()
as before?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s.t.Snapshot()
now returns the new trie to be modified, previously it returned the old trie to be saved ands.t
would continue to be modified