-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib/babe): fix setting first slot of network, fix loading BABE epoch params #1640
Merged
Merged
Changes from 94 commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
e92668d
add 3 auth genesis
noot 8a67205
Merge branch 'noot/devnet-genesis' into noot/fix-babe-epoch
noot f893b82
improve epoch transition logic
noot 37e457a
implement code substitutes
edwardmack a919188
fix babe tests
noot c23fee5
add wait until epoch starts
noot d23f2be
lint
noot 52d0f73
merge w development
noot 5cccb37
Merge branch 'development' into ed/code_substitutes
edwardmack b6c88b1
cleanup
noot 578ff9c
restore genesis
noot 6177b10
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot a49b3b5
add log
noot f3182de
set first slot only if block 1 not final; make unchangeable after blo…
noot 74d73f6
fix setting of babe epoch data on restart after first epoch
noot 17181f4
move digest handler to its own package; handle digests after built block
noot a5cfb7c
fmt
noot cdee399
fix babe tests
noot 46dbf3b
cleanup core interfaces, fix digest package tests
noot 74f6ade
add small wait before initiating babe
noot b42e644
lint, test fixes
noot a97a55b
cleanup, test epoch transition w 3 nodes
noot af18efb
fix
noot 13cf25c
address comments
noot 0b7e8f5
Merge branch 'noot/fix-babe-epoch' of github.com:ChainSafe/gossamer i…
noot e1ea906
increase test epoch length
noot 2544e1e
merge w other branch
noot 2a57a77
cleanup
noot 2fb14ed
lint
noot fe09256
remove unused code
noot 67227e9
start to fix tests
noot da1d50e
Merge branch 'development' into ed/code_substitutes
edwardmack 18460c8
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot af33101
add go.mod
noot d2f38b2
update b.Paused to close channel
noot 74f68f7
merge w development
noot eb63f16
fix
noot d580158
address PR comments
edwardmack 27dc09f
update babe.Pause
noot 7a5ce9e
remove unneeded files
noot 749da75
add pause/resume test
noot 1058a9a
lint
noot df318d6
small cleanup
noot 5716370
Merge branch 'ed/code_substitutes' into noot/block-handle-refactor
noot f474f14
begin core handle block import refactor
noot b7af203
move digest handler to its own package
noot ce94028
move AddBlock and StoreTrie logic to core.handleBlock
noot 9e4364b
update babe to use core.HandleBlockImport
noot a2f5452
merge w development
noot 5d40e3d
fix test
noot f36e546
merge w development
noot 9984b89
add handler to babe cfg
noot 7ef0e79
cleanup
noot ed5ad02
set core digestHandler
noot 74a3d19
fix dot, core, sync tests
noot 5c4dff5
lint
noot 29a4f10
merge w development
noot 034a685
cleanup
noot a0ac8e7
cleanup
noot d71ae70
fix unit tests
noot 0f52ff1
fix
noot 9bc76ee
add lock for closing/writing to core blockAddCh
noot 4010684
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 7598f83
store trie before adding block
noot b6bd916
fix
noot 033d499
merge w refactor branch
noot 786dc1c
fix unit tests
noot c7e724f
Merge branch 'noot/block-handle-refactor' of github.com:ChainSafe/gos…
noot 4b67fe7
fix sync tests
noot f50ebaf
fix dot test
noot 73c4168
fix babe to use correct handler func
noot 35f38bc
lint
noot 62b7277
fix babe to use right handler func
noot d1b23b1
fix
noot 4d4942a
fix unit test
noot ff3d140
merge w development
noot 68c130e
add go.sum
noot 589380e
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 95ed8fb
merge w development
noot da1615c
Merge branch 'noot/block-handle-refactor' of github.com:ChainSafe/gos…
noot d1ad9cf
add dot/state unit tests, fix dot/digest tests
noot 692d6b5
merge w development
noot 37e3942
fix rpc tests
noot 3433473
restore genesis, fix grandpa tests
noot bdd4cdc
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot 02d013d
fix grandpa tests
noot 9feab39
fix rpc tests
noot 5ffbf8f
add unit tests for babe setupParameters
noot 059eff3
lint
noot c2feee1
lint
noot c6c4769
fix rpc integration tests
noot ffa805e
cleanup
noot 8eb50e9
address comments
noot 63e009b
lint
noot 7dc7f22
Merge branch 'development' of github.com:ChainSafe/gossamer into noot…
noot d4aabcf
address comments
noot 4f81dbe
add go.mod
noot df6ae53
Merge branch 'development' into noot/fix-first-slot
noot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to listen on some sort of channel that can be triggered when the waitGroup is done? That way we don't have to wait on arbitrary delays, which could vary from system to system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to have a
started
channel in*Node
that's closed when all the services are started