Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dot/state): fix runtime panic due to stopped runtime #1705

Merged
merged 3 commits into from
Jul 23, 2021
Merged

fix(dot/state): fix runtime panic due to stopped runtime #1705

merged 3 commits into from
Jul 23, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Jul 22, 2021

Changes

  • runtime was being stopped when it was pruned; however valid blocks might be pruned from the blocktree if they're past the most recent finalized head, causing the runtime referenced by newer blocks also to be stopped
  • don't stop runtime in blocktree prune anymore since unpruned blocks might reference it

Tests

run a dev node before/after and see that this no longer panics

Issues

@noot noot self-assigned this Jul 22, 2021
@noot noot merged commit 3606069 into noot/fix-trie-state Jul 23, 2021
@noot noot deleted the noot/fix-runtime branch July 23, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@arijitAD arijitAD Awaiting requested review from arijitAD

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20

Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noot @EclesioMeloJunior @dutterbutter