feat(dot/rpc) implement chain_subscribeAllHeads RPC
#1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclesioMeloJunior
requested review from
arijitAD,
edwardmack,
jimjbrettj,
noot and
timwu20
as code owners
timwu20
requested changes
Aug 20, 2021
dot/rpc/subscription/listeners.go
Outdated
| continue | ||
| } | ||
|
|
||
| res := newSubcriptionBaseResponseJSON() |
There was a problem hiding this comment.
can you change this constructor to just take Method and Params. Seems odd that we need to populate it ourselves.
dot/rpc/subscription/websocket.go
Outdated
Comment on lines
282
to
288
| listener := new(AllBlocksListener) | ||
| listener.cancel = make(chan struct{}) | ||
| listener.done = make(chan struct{}) | ||
| listener.cancelTimeout = defaultCancelTimeout | ||
| listener.wsconn = c | ||
| listener.finalizedChan = make(chan *types.FinalisationInfo, DEFAULT_BUFFER_SIZE) | ||
| listener.importedChan = make(chan *types.Block, DEFAULT_BUFFER_SIZE) |
There was a problem hiding this comment.
move to constructor newAllBlocksListener
Codecov Report
@@ Coverage Diff @@
## development #1740 +/- ##
===============================================
+ Coverage 59.08% 59.10% +0.02%
===============================================
Files 184 184
Lines 19336 19396 +60
===============================================
+ Hits 11424 11464 +40
- Misses 5931 5945 +14
- Partials 1981 1987 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
timwu20
approved these changes
Aug 23, 2021
arijitAD
approved these changes
Aug 24, 2021
noot
reviewed
Aug 24, 2021
Co-authored-by: noot <36753753+noot@users.noreply.github.com>
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
* feat: implement chain subscribe all heads * chore: add unit tests to subscribe all heads * chore: fix lint * chore: create constructor * chore: improve AllBlocksListener export comment Co-authored-by: noot <36753753+noot@users.noreply.github.com> Co-authored-by: noot <36753753+noot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
chain_subscribeAllHeadsandchain_unsubscribeAllHeadsBlockAPIand notify the websocket every new block or finalizationTests
Issues
chain_subscribeAllHeadsrpc method #1741Primary Reviewer