Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): Check PR body and title. #1786

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Conversation

arijitAD
Copy link
Contributor

@arijitAD arijitAD commented Sep 13, 2021

Changes

  • Check PR body and title.

Tests

Test_PR_Checks

Issues

  • None

Primary Reviewer

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1786 (a87ce86) into development (0064836) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1786      +/-   ##
===============================================
- Coverage        59.35%   59.34%   -0.02%     
===============================================
  Files              186      187       +1     
  Lines            20052    20069      +17     
===============================================
+ Hits             11902    11910       +8     
- Misses            6092     6102      +10     
+ Partials          2058     2057       -1     
Flag Coverage Δ
unit-tests 59.34% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/utils/pull_request.go 100.00% <100.00%> (ø)
dot/network/sync.go 60.94% <0.00%> (-2.77%) ⬇️
lib/babe/babe.go 56.70% <0.00%> (-1.15%) ⬇️
lib/blocktree/blocktree.go 55.61% <0.00%> (-1.13%) ⬇️
lib/babe/epoch.go 66.66% <0.00%> (+2.15%) ⬆️
dot/state/block_notify.go 82.95% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0064836...a87ce86. Read the comment docs.

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - potentially we could check that the title starts with one of "chore", "fix", "maintainence", "feature" etc. as well.

I'd prefer to leave this unrequired for now as well, in case of external contributors perhaps deviating from the format (they shouldn't, but it might be confusing for them). we can discuss more on standup though!

@arijitAD
Copy link
Contributor Author

looks good - potentially we could check that the title starts with one of "chore", "fix", "maintainence", "feature" etc. as well.

I'd prefer to leave this unrequired for now as well, in case of external contributors perhaps deviating from the format (they shouldn't, but it might be confusing for them). we can discuss more on standup though!

Yes, I feel the same. It should not be a mandatory check but it just automates the check for proper PR title and body.

@arijitAD arijitAD merged commit bd4e06d into development Sep 17, 2021
@arijitAD arijitAD deleted the pr-description-check branch September 17, 2021 15:28
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
* chore(CI): Check PR body and title.

* Trigger CI

* Fix regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants