-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): Check PR body and title. #1786
Conversation
e821362
to
de2b00f
Compare
de2b00f
to
1e04ce1
Compare
Codecov Report
@@ Coverage Diff @@
## development #1786 +/- ##
===============================================
- Coverage 59.35% 59.34% -0.02%
===============================================
Files 186 187 +1
Lines 20052 20069 +17
===============================================
+ Hits 11902 11910 +8
- Misses 6092 6102 +10
+ Partials 2058 2057 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - potentially we could check that the title starts with one of "chore", "fix", "maintainence", "feature" etc. as well.
I'd prefer to leave this unrequired for now as well, in case of external contributors perhaps deviating from the format (they shouldn't, but it might be confusing for them). we can discuss more on standup though!
Yes, I feel the same. It should not be a mandatory check but it just automates the check for proper PR title and body. |
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* chore(CI): Check PR body and title. * Trigger CI * Fix regex.
Changes
Tests
Issues
Primary Reviewer