chore: Add scale.Decoder and update lib/trie integration
#1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot and
omar391
as code owners
Codecov Report
@@ Coverage Diff @@
## development #1896 +/- ##
===============================================
- Coverage 59.61% 59.60% -0.02%
===============================================
Files 187 187
Lines 19110 19129 +19
===============================================
+ Hits 11393 11402 +9
- Misses 5825 5832 +7
- Partials 1892 1895 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
timwu20
force-pushed
the
tim/scale-decoder
branch
from
23a2822
to
8c250ef
Compare
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
added a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
…#1896) * add Decoder, update lib/trie integration, add tests * update tests * add error case tests * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
scale.Decodertopkg/scale, and associated constructorDecoder.Decode()in remaininglib/trieintegration where we need stateful decodingDecoderTests
Issues
Primary Reviewer