Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(cmd/gossamer): README for cmd package #1929

Merged
merged 7 commits into from
Nov 5, 2021
Merged

doc(cmd/gossamer): README for cmd package #1929

merged 7 commits into from
Nov 5, 2021

Conversation

danforbes
Copy link
Contributor

@danforbes danforbes commented Oct 26, 2021 •
edited
Loading

Changes

Added README for cmd package.

Tests

N/A

Issues

N/A

Primary Reviewer

@noot

@codecov
Copy link

codecov bot commented Oct 26, 2021 •
edited
Loading

Codecov Report

Merging #1929 (891b21d) into development (90d200f) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1929      +/-   ##
===============================================
+ Coverage        60.26%   60.29%   +0.03%     
===============================================
  Files              180      180              
  Lines            18205    18205              
===============================================
+ Hits             10971    10977       +6     
+ Misses            5420     5417       -3     
+ Partials          1814     1811       -3
Flag Coverage Δ
unit-tests 60.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/grandpa/grandpa.go 59.64% <0.00%> (+0.32%) ⬆️
lib/grandpa/vote_message.go 84.56% <0.00%> (+1.23%) ⬆️
lib/grandpa/message.go 65.68% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d200f...891b21d. Read the comment docs.

qdm12
qdm12 reviewed Oct 26, 2021
View reviewed changes
README.md Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
@danforbes @qdm12
Apply @qdm12 suggestions from code review
1598eba 
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! just a few comments :)

@danforbes danforbes requested review from noot and qdm12 November 2, 2021 18:35
noot
noot reviewed Nov 4, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot reviewed Nov 4, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
noot
noot approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! just a couple comments, but basically good to go :D

qdm12
qdm12 approved these changes Nov 5, 2021
View reviewed changes
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Outdated Show resolved Hide resolved
cmd/gossamer/README.md Show resolved Hide resolved
cmd/gossamer/README.md Show resolved Hide resolved
@danforbes danforbes changed the title README for the cmd package doc(cmd/gossamer): README for cmd package Nov 5, 2021
@danforbes danforbes merged commit 688c265 into development Nov 5, 2021
@danforbes danforbes deleted the dforbes/doc/cmd branch November 5, 2021 15:53
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
@danforbes @qdm12 @timwu20
doc(cmd/gossamer): README for cmd package (ChainSafe#1929)
6098ff1 
* README for the cmd package

* Apply @qdm12 suggestions from code review

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>

* Review changes

* Review comments

* chore(ci): Fix PR check (again) (ChainSafe#1960)

* Standarize lists

Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot approved these changes

@qdm12 qdm12 qdm12 approved these changes

@arijitAD arijitAD Awaiting requested review from arijitAD

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior

@edwardmack edwardmack Awaiting requested review from edwardmack

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@omar391 omar391 Awaiting requested review from omar391

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danforbes @qdm12 @noot