Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(issue): user story issue template #1956

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Nov 1, 2021

Changes

  • User story issue yml template
    • Dropdown As a
    • Textarea I want to
    • Textarea Because

Tests

  • Not relevant

Issues

  • No issue

Primary Reviewer

For the curious, yml github issue template syntax

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1956 (2b8c255) into development (69823c0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1956      +/-   ##
===============================================
- Coverage        60.12%   60.10%   -0.02%     
===============================================
  Files              180      180              
  Lines            18086    18086              
===============================================
- Hits             10874    10871       -3     
  Misses            5408     5408              
- Partials          1804     1807       +3     
Flag Coverage Δ
unit-tests 60.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/grandpa/message.go 63.72% <0.00%> (-1.97%) ⬇️
lib/grandpa/vote_message.go 83.33% <0.00%> (-1.24%) ⬇️
dot/network/service.go 69.09% <0.00%> (-1.17%) ⬇️
dot/network/connmgr.go 79.64% <0.00%> (+0.88%) ⬆️
dot/network/test_helpers.go 82.10% <0.00%> (+4.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69823c0...2b8c255. Read the comment docs.

@danforbes
Copy link
Contributor

Thanks for creating this, Quentin 🙏🏻 I'm not sure if I think that this template is necessary for now, but I will add some resources for us to refer to if we decide to prioritize this.

@qdm12
Copy link
Contributor Author

qdm12 commented Nov 8, 2021

@danforbes actually I wouldn't mind having an extra template option for user stories, so we can use them optionally (if we feel like it/like it applies).

@danforbes
Copy link
Contributor

@qdm12 - approved!

@qdm12
Copy link
Contributor Author

qdm12 commented Nov 8, 2021

Yayy 🎉 We can always modify or remove it later if we feel like it!

@qdm12 qdm12 merged commit 6b153e9 into development Nov 8, 2021
@qdm12 qdm12 deleted the qdm12-user-story-issue-template branch November 8, 2021 22:05
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit to timwu20/gossamer that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants